Bug 57632 – Web Inspector: appropriateSelectorForNode() invokes the "localName" getter on DOMNode rather than function

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Alexander Pavlov (apavlov)]

As advised by pfeldman, appropriateSelectorForNode() should become DOMNode.prototype.appropriateSelectorFor.

This is the root cause of http://code.google.com/p/chromium/issues/detail?id=77531

[Alexander Pavlov (apavlov)]

Created attachment 87869 [details]
[PATCH] Suggested fix

[Alexander Pavlov (apavlov)]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
        M       Source/WebCore/ChangeLog
        M       Source/WebCore/inspector/front-end/DOMAgent.js
        M       Source/WebCore/inspector/front-end/EventListenersSidebarPane.js
        M       Source/WebCore/inspector/front-end/StylesSidebarPane.js
        M       Source/WebCore/inspector/front-end/utilities.js
Committed r82818

[Pavel Feldman]

Comment on attachment 87869 [details]
[PATCH] Suggested fix

View in context: https://bugs.webkit.org/attachment.cgi?id=87869&action=review

> Source/WebCore/inspector/front-end/DOMAgent.js:228
> +        var lowerCaseName = this.localName() || node.nodeName().toLowerCase();

Alexander, Yury, this code is not right: "node" is not defined in this context. Could you please cover this with a test?