Bug 57630

Summary: Leaks viewer gets some revision numbers wrong in the recent builds list
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Retrieve revision numbers from the build's got_revision property in Leaks Viewer andersca: review+

Adam Roben (:aroben)
Reported 2011-04-01 07:21:10 PDT
Leaks viewer gets some revision numbers wrong in the recent builds list. For instance, right now it has a link to <http://build.webkit.org/LeaksViewer/?url=http%3A%2F%2Fbuild.webkit.org%2F%2Fresults%2FSnowLeopard%20Intel%20Leaks%2Fr82671%20(15955)%2F>, but labels it as r82669, instead of r82671.
Attachments
Retrieve revision numbers from the build's got_revision property in Leaks Viewer (3.14 KB, patch)
2011-04-01 07:33 PDT, Adam Roben (:aroben) 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2011-04-01 07:33:46 PDT
Created attachment 87855 [details] Retrieve revision numbers from the build's got_revision property in Leaks Viewer
WebKit Review Bot
Comment 2 2011-04-01 07:38:35 PDT
Attachment 87855 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/BuildSlaveSupport/build.webkit.org-c..." exit_code: 1 Tools/ChangeLog:3: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Adam Roben (:aroben)
Comment 3 2011-04-01 08:19:27 PDT
Committed r82682: <http://trac.webkit.org/changeset/82682>
Note You need to log in before you can comment on or make changes to this bug.