Bug 57622

Summary: Web Inspector: [Extensions API] Merge WatchExpressionSidebarPane into ExtensionSidebarPane
Product: WebKit Reporter: Andrey Kosyakov <caseq>
Component: Web Inspector (Deprecated)Assignee: Andrey Kosyakov <caseq>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, apavlov, bweinstein, eric, joepeck, keishi, loislo, pfeldman, pmuellr, rik, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
yurys: review-
patch yurys: review+

Description Andrey Kosyakov 2011-04-01 06:06:07 PDT 
ExtensionSidebarPane.setPage() will set content of the sidebar to page specified.
Comment 1 Andrey Kosyakov 2011-04-01 06:06:47 PDT 
Created attachment 87851 [details]
patch
Comment 2 Yury Semikhatsky 2011-04-04 00:54:24 PDT 
Comment on attachment 87851 [details]
patch

ChangeLog entry is missing, otherwise looks good.
Comment 3 Andrey Kosyakov 2011-04-04 01:10:09 PDT 
Created attachment 88041 [details]
patch

Oops. Added ChangeLog entries.
Comment 4 WebKit Review Bot 2011-04-04 02:31:31 PDT 
http://trac.webkit.org/changeset/82806 might have broken SnowLeopard Intel Release (Tests)
The following tests are not passing:
inspector/extensions/extensions-api.html
inspector/extensions/extensions.html
Comment 5 Andrey Kosyakov 2011-04-04 07:28:43 PDT 
Manually committed as r82206: http://trac.webkit.org/changeset/82806
Follow-up fix in r82814: http://trac.webkit.org/changeset/82814