Bug 57568

Summary:

WebKitTestRunner needs layoutTestController.setDatabaseQuota

Product:

WebKit

Reporter:

Chang Shu <cshu>

Component:

Tools / Tests

Assignee:

Chang Shu <cshu>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, buildbot, cdumez, commit-queue, eric, webkit-ews, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Bug Depends on:

Bug Blocks:

57570

Attachments:

Description	Flags
fix patch	none
fix patch 2: fix build break	none

Description Chang Shu 2011-03-31 13:15:41 PDT

Failed layout tests include at least:
storage/open-database-creation-callback.html

Comment 1 Chang Shu 2011-04-01 08:25:05 PDT

Created attachment 87859 [details]
fix patch

Comment 2 Early Warning System Bot 2011-04-01 08:44:52 PDT

Attachment 87859 [details] did not build on qt:
Build output: http://queues.webkit.org/results/8319193

Comment 3 Chang Shu 2011-04-01 09:04:06 PDT

Created attachment 87866 [details]
fix patch 2: fix build break

Comment 4 Build Bot 2011-04-01 09:28:39 PDT

Attachment 87859 [details] did not build on win:
Build output: http://queues.webkit.org/results/8307198

Comment 5 WebKit Commit Bot 2011-04-01 12:57:06 PDT

The commit-queue encountered the following flaky tests while processing attachment 87866 [details]:

http/tests/loading/load-javascript-after-many-xhrs.html bug 57652 (author: hayato@chromium.org)
The commit-queue is continuing to process your patch.

Comment 6 WebKit Commit Bot 2011-04-01 12:59:44 PDT

Comment on attachment 87866 [details]
fix patch 2: fix build break

Clearing flags on attachment: 87866

Committed r82710: <http://trac.webkit.org/changeset/82710>

Comment 7 WebKit Commit Bot 2011-04-01 12:59:48 PDT

All reviewed patches have been landed.  Closing bug.

Comment 8 WebKit Review Bot 2011-04-01 13:35:47 PDT

http://trac.webkit.org/changeset/82710 might have broken Windows 7 Release (Tests)

Comment 9 Chris Dumez 2012-09-14 06:20:28 PDT

Comment on attachment 87866 [details]
fix patch 2: fix build break

View in context: https://bugs.webkit.org/attachment.cgi?id=87866&action=review

> Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:130
> +    WebDatabaseManager::shared().setQuotaForOrigin("file:///", quota);

WebDatabaseManager::setQuotaForOrigin() actually expects a databaseIdentifier so "file:///" does not work here (I believe "file__0" is what we use as databaseIdentifier for local files). I'm addressing the issue in Bug 57570. I noticed the problem after adding the database callbacks dumping.