Summary: | Web Inspector: CSS domain - make a "range" object, get rid of "properties" object for Style objects | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexander Pavlov (apavlov) <apavlov> | ||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Alexander Pavlov (apavlov) <apavlov> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, apavlov, bweinstein, eric, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Alexander Pavlov (apavlov)
2011-03-31 04:49:30 PDT
Created attachment 87706 [details]
[PATCH] Suggested solution
Created attachment 87707 [details]
[
Created attachment 87708 [details]
[PATCH] Remove inadvertently added blank line
Comment on attachment 87708 [details] [PATCH] Remove inadvertently added blank line View in context: https://bugs.webkit.org/attachment.cgi?id=87708&action=review > LayoutTests/inspector/styles/styles-source-offsets.html:12 > + function rangeText(range) Can you move this method into a common file for inspector CSS tests? > LayoutTests/inspector/styles/styles-source-offsets.html:33 > + InspectorTest.addResult(header + " [" + style.range.start + "-" + style.range.end + "]"); Please use rangeText instead. http://trac.webkit.org/changeset/82578 might have broken GTK Linux 32-bit Release Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/http/tests/inspector/elements-test.js M LayoutTests/inspector/styles/get-set-stylesheet-text.html M LayoutTests/inspector/styles/styles-new-API.html M LayoutTests/inspector/styles/styles-source-offsets.html M Source/WebCore/ChangeLog M Source/WebCore/inspector/InspectorStyleSheet.cpp M Source/WebCore/inspector/front-end/AuditRules.js M Source/WebCore/inspector/front-end/CSSStyleModel.js Committed r82578 |