Bug 57538

Summary: Web Inspector: CSS domain - make a "range" object, get rid of "properties" object for Style objects
Product: WebKit Reporter: Alexander Pavlov (apavlov) <apavlov>
Component: Web Inspector (Deprecated)Assignee: Alexander Pavlov (apavlov) <apavlov>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, apavlov, bweinstein, eric, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Suggested solution
none
[
none
[PATCH] Remove inadvertently added blank line yurys: review+

Description Alexander Pavlov (apavlov) 2011-03-31 04:49:30 PDT
"startOffset"/"endOffset" should reside in a separate "range" object, and the "properties" object (for the CSS style) should go away (width/height get inlined into the CSS style object).
Comment 1 Alexander Pavlov (apavlov) 2011-03-31 05:44:14 PDT
Created attachment 87706 [details]
[PATCH] Suggested solution
Comment 2 Alexander Pavlov (apavlov) 2011-03-31 05:46:20 PDT
Created attachment 87707 [details]
[
Comment 3 Alexander Pavlov (apavlov) 2011-03-31 05:47:11 PDT
Created attachment 87708 [details]
[PATCH] Remove inadvertently added blank line
Comment 4 Yury Semikhatsky 2011-03-31 06:57:51 PDT
Comment on attachment 87708 [details]
[PATCH] Remove inadvertently added blank line

View in context: https://bugs.webkit.org/attachment.cgi?id=87708&action=review

> LayoutTests/inspector/styles/styles-source-offsets.html:12
> +    function rangeText(range)

Can you move this method into a common file for inspector CSS tests?

> LayoutTests/inspector/styles/styles-source-offsets.html:33
> +        InspectorTest.addResult(header + " [" + style.range.start  + "-" + style.range.end + "]");

Please use rangeText instead.
Comment 5 WebKit Review Bot 2011-03-31 08:28:03 PDT
http://trac.webkit.org/changeset/82578 might have broken GTK Linux 32-bit Release
Comment 6 Alexander Pavlov (apavlov) 2011-03-31 09:00:08 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	M	LayoutTests/http/tests/inspector/elements-test.js
	M	LayoutTests/inspector/styles/get-set-stylesheet-text.html
	M	LayoutTests/inspector/styles/styles-new-API.html
	M	LayoutTests/inspector/styles/styles-source-offsets.html
	M	Source/WebCore/ChangeLog
	M	Source/WebCore/inspector/InspectorStyleSheet.cpp
	M	Source/WebCore/inspector/front-end/AuditRules.js
	M	Source/WebCore/inspector/front-end/CSSStyleModel.js
Committed r82578