Bug 57529

Summary:

WebKit2: Save as PDF in Safari provides Untitled as default file name

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

PDF

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED FIXED

Severity:

Normal

Keywords:

InRadar, PlatformOnly

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.6

Attachments:

Description	Flags
Patch	mitz: review+

Description Jer Noble 2011-03-31 00:51:19 PDT

When saving as PDF from Safari, the default file name provided is Untitled.

Comment 1 Jer Noble 2011-03-31 00:51:36 PDT

<rdar://problem/8998510>

Comment 2 Jer Noble 2011-03-31 01:26:00 PDT

Created attachment 87679 [details]
Patch

Comment 3 Alexey Proskuryakov 2011-04-01 09:15:18 PDT

Comment on attachment 87679 [details]
Patch

Interestingly, this is not how it works in WebKit1 - my theory is that NSPrintOperation gets job title from window title by default, but WKPrintingView doesn't have a window.

Comment 4 Jer Noble 2011-04-01 10:10:04 PDT

That's exactly right.  [NSPrintOperation setJobTitle:] overrides the default behavior, which is to call [NSView printJobTitle], which returns the document's displayName.

Comment 5 Jer Noble 2011-04-01 16:08:40 PDT

Committed r82737: <http://trac.webkit.org/changeset/82737>