Bug 57518

Summary: Clean up the sandbox parameter code
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch sam: review+

Description Anders Carlsson 2011-03-30 18:38:43 PDT
Clean up the sandbox parameter code
Comment 1 Anders Carlsson 2011-03-30 18:41:11 PDT
Created attachment 87653 [details]
Patch
Comment 2 Sam Weinig 2011-03-30 18:43:06 PDT
Comment on attachment 87653 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=87653&action=review

> Source/WebKit2/WebProcess/mac/WebProcessMac.mm:153
> +static void appendReadonlySandboxDirectory(Vector<const char*>& vector, const char* name, const String& path)
> +{
> +    appendSandboxParameterPathInternal(vector, name, [(NSString *)path fileSystemRepresentation]);
> +}
> +
> +static void appendReadwriteSandboxDirectory(Vector<const char*>& vector, const char* name, const String& path)
> +{
> +    appendSandboxParameterPathInternal(vector, name, [(NSString *)path fileSystemRepresentation]);
> +}

These should take NSStrings.
Comment 3 Anders Carlsson 2011-03-30 18:45:28 PDT
Committed r82530: <http://trac.webkit.org/changeset/82530>