Bug 57518

Summary: Clean up the sandbox parameter code
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch sam: review+

Anders Carlsson
Reported 2011-03-30 18:38:43 PDT
Clean up the sandbox parameter code
Attachments
Patch (8.89 KB, patch)
2011-03-30 18:41 PDT, Anders Carlsson 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2011-03-30 18:41:11 PDT
Created attachment 87653 [details] Patch
Sam Weinig
Comment 2 2011-03-30 18:43:06 PDT
Comment on attachment 87653 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=87653&action=review > Source/WebKit2/WebProcess/mac/WebProcessMac.mm:153 > +static void appendReadonlySandboxDirectory(Vector<const char*>& vector, const char* name, const String& path) > +{ > + appendSandboxParameterPathInternal(vector, name, [(NSString *)path fileSystemRepresentation]); > +} > + > +static void appendReadwriteSandboxDirectory(Vector<const char*>& vector, const char* name, const String& path) > +{ > + appendSandboxParameterPathInternal(vector, name, [(NSString *)path fileSystemRepresentation]); > +} These should take NSStrings.
Anders Carlsson
Comment 3 2011-03-30 18:45:28 PDT
Committed r82530: <http://trac.webkit.org/changeset/82530>
Note You need to log in before you can comment on or make changes to this bug.