Bug 57489

Summary:

Mac builders built 82512, but shouldn't have

Product:

WebKit

Reporter:

Adam Roben (:aroben) <aroben>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
Mark .vcproj/.vsprops/.sln files as being Windows-only	andersca: review+

Description Adam Roben (:aroben) 2011-03-30 11:41:20 PDT

r82477 changed a bunch of Windows-only files, but the Mac builders built it anyway. They should have skipped this revision. For example, <http://build.webkit.org/builders/Leopard%20Intel%20Release%20%28Build%29/builds/32497>.

Comment 1 Adam Roben (:aroben) 2011-04-01 06:51:36 PDT

Turns out r82477 touched webkitdirs.pm, so triggering a build was valid. But it looks like the Mac builders will build in response to any .vcproj/.vsprops/.sln file change, and we should fix that.

r82512 is a better example.

Comment 2 Adam Roben (:aroben) 2011-04-01 06:57:51 PDT

Created attachment 87854 [details]
Mark .vcproj/.vsprops/.sln files as being Windows-only

Comment 3 Adam Roben (:aroben) 2011-04-01 07:10:49 PDT

Committed r82679: <http://trac.webkit.org/changeset/82679>