Bug 57457

Summary: Add support for parsing unicode-bidi:plaintext
Product: WebKit Reporter: Ofri Wolfus <ofri>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 57482    
Bug Blocks: 50949    
Attachments:
Description Flags
Patch none

Ofri Wolfus
Reported 2011-03-30 08:01:12 PDT
Add support for parsing unicode-bidi:plaintext
Attachments
Patch (6.40 KB, patch)
2011-03-30 08:06 PDT, Ofri Wolfus 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ofri Wolfus
Comment 1 2011-03-30 08:06:27 PDT
Created attachment 87538 [details] Patch
WebKit Review Bot
Comment 2 2011-03-30 08:09:55 PDT
Attachment 87538 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/css3..." exit_code: 1 Source/WebCore/rendering/style/RenderStyle.h:258: _unicodeBidi is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Eric Seidel (no email)
Comment 3 2011-03-30 08:23:36 PDT
Comment on attachment 87538 [details] Patch LGTM.
WebKit Commit Bot
Comment 4 2011-03-30 10:20:42 PDT
Comment on attachment 87538 [details] Patch Clearing flags on attachment: 87538 Committed r82463: <http://trac.webkit.org/changeset/82463>
WebKit Commit Bot
Comment 5 2011-03-30 10:20:48 PDT
All reviewed patches have been landed. Closing bug.
Eric Seidel (no email)
Comment 6 2011-03-30 11:41:40 PDT
I suspect this is hitting an ASSERT in the BidiResolver code which I ran across today. Ofri and I can look into it tomorrow.
Eric Seidel (no email)
Comment 7 2011-03-30 12:02:18 PDT
Hmm... the backtrac was not as expected: http://build.webkit.org/results/Leopard%20Intel%20Debug%20%28Tests%29/r82463%20(28266)/editing/deleting/5408255-crash-log.txt
Note You need to log in before you can comment on or make changes to this bug.