Summary: | Add support for parsing unicode-bidi:plaintext | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ofri Wolfus <ofri> | ||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, eric, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | 57482 | ||||||
Bug Blocks: | 50949 | ||||||
Attachments: |
|
Description
Ofri Wolfus
2011-03-30 08:01:12 PDT
Created attachment 87538 [details]
Patch
Attachment 87538 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/css3..." exit_code: 1
Source/WebCore/rendering/style/RenderStyle.h:258: _unicodeBidi is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Total errors found: 1 in 9 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 87538 [details]
Patch
LGTM.
Comment on attachment 87538 [details] Patch Clearing flags on attachment: 87538 Committed r82463: <http://trac.webkit.org/changeset/82463> All reviewed patches have been landed. Closing bug. I suspect this is hitting an ASSERT in the BidiResolver code which I ran across today. Ofri and I can look into it tomorrow. Hmm... the backtrac was not as expected: http://build.webkit.org/results/Leopard%20Intel%20Debug%20%28Tests%29/r82463%20(28266)/editing/deleting/5408255-crash-log.txt |