Summary: | REGRESSION(r82419): New pixel test failure fast/box-shadow/basic-shadows.html | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yuta Kitamura <yutak> | ||||||||
Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, eric, sam, yael | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Yuta Kitamura
2011-03-30 05:04:06 PDT
Created attachment 87505 [details]
Actual result
Created attachment 87506 [details]
Expected result
Sorry about the regression. What port is doing that? I don't see it on the mac build bot. At least, all Chromium bots are affected. I think this can be reproduced on all ports. The bots in WebKit waterfall do not run pixel tests. You can try it (even on Apple's Mac port) manually with: run-webkit-tests -p --tolerance=0 fast/box-shadow/basic-shadows.html Created attachment 87542 [details]
Patch
Don't consider br as text when evaluating the logically last run to decide if it is last for its renderer.
Comment on attachment 87542 [details]
Patch
OK. Sad this is only covered by pixel tests.
Comment on attachment 87542 [details] Patch Clearing flags on attachment: 87542 Committed r82461: <http://trac.webkit.org/changeset/82461> All reviewed patches have been landed. Closing bug. |