Bug 57440

Summary: Web Inspector: Make the getStylesForNode result "styleAttributes" value an array rather than a map
Product: WebKit Reporter: Alexander Pavlov (apavlov) <apavlov>
Component: Web Inspector (Deprecated)Assignee: Alexander Pavlov (apavlov) <apavlov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Suggested solution pfeldman: review+

Alexander Pavlov (apavlov)
Reported 2011-03-30 03:44:00 PDT
Having a map instead of an array does not enable us to define the object keys domain, and also prevents a proper documentation of the data types in Inspector.json
Attachments
[PATCH] Suggested solution (6.52 KB, patch)
2011-03-30 04:52 PDT, Alexander Pavlov (apavlov) 		pfeldman: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexander Pavlov (apavlov)
Comment 1 2011-03-30 04:52:57 PDT
Created attachment 87502 [details] [PATCH] Suggested solution
WebKit Review Bot
Comment 2 2011-03-30 04:55:09 PDT
Attachment 87502 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/insp..." exit_code: 1 Source/WebCore/inspector/InspectorCSSAgent.h:94: The parameter name "element" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alexander Pavlov (apavlov)
Comment 3 2011-03-30 06:39:15 PDT
Landed with a style fix. Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/inspector/styles/styles-new-API.html M Source/WebCore/ChangeLog M Source/WebCore/inspector/InspectorCSSAgent.cpp M Source/WebCore/inspector/InspectorCSSAgent.h M Source/WebCore/inspector/front-end/CSSStyleModel.js Committed r82433
Note You need to log in before you can comment on or make changes to this bug.