Bug 57440 - Web Inspector: Make the getStylesForNode result "styleAttributes" value an array rather than a map
Summary: Web Inspector: Make the getStylesForNode result "styleAttributes" value an ar...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexander Pavlov (apavlov)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-30 03:44 PDT by Alexander Pavlov (apavlov)
Modified: 2011-03-30 06:39 PDT (History)
11 users (show)

See Also:

Attachments
[PATCH] Suggested solution (6.52 KB, patch)
2011-03-30 04:52 PDT, Alexander Pavlov (apavlov) 		pfeldman: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Pavlov (apavlov) 2011-03-30 03:44:00 PDT 
Having a map instead of an array does not enable us to define the object keys domain, and also prevents a proper documentation of the data types in Inspector.json
Comment 1 Alexander Pavlov (apavlov) 2011-03-30 04:52:57 PDT 
Created attachment 87502 [details]
[PATCH] Suggested solution
Comment 2 WebKit Review Bot 2011-03-30 04:55:09 PDT 
Attachment 87502 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/insp..." exit_code: 1

Source/WebCore/inspector/InspectorCSSAgent.h:94:  The parameter name "element" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alexander Pavlov (apavlov) 2011-03-30 06:39:15 PDT 
Landed with a style fix.

Committing to http://svn.webkit.org/repository/webkit/trunk ...
        M       LayoutTests/ChangeLog
        M       LayoutTests/inspector/styles/styles-new-API.html
        M       Source/WebCore/ChangeLog
        M       Source/WebCore/inspector/InspectorCSSAgent.cpp
        M       Source/WebCore/inspector/InspectorCSSAgent.h
        M       Source/WebCore/inspector/front-end/CSSStyleModel.js
Committed r82433