Bug 57432

Summary: Split out handling of trailing spaces from layoutInlineChildren
Product: WebKit Reporter: Eric Seidel <eric>
Component: New BugsAssignee: Eric Seidel <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, mitz, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Mac OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Eric Seidel 2011-03-30 02:09:44 PDT
Split out handling of trailing spaces from layoutInlineChildren
Comment 1 Eric Seidel 2011-03-30 02:11:29 PDT
Created attachment 87484 [details]
Patch
Comment 2 mitz@webkit.org 2011-03-30 08:10:45 PDT
Comment on attachment 87484 [details]
Patch

Nice. I would have made this a static function with a const RenderBlock* parameter.
Comment 3 Eric Seidel 2011-03-30 08:21:59 PDT
Comment on attachment 87484 [details]
Patch

(In reply to comment #2)
> (From update of attachment 87484 [details])
> Nice. I would have made this a static function with a const RenderBlock* parameter.

I thought about that.  But this reads cleaner (but has more perf risk).  If the PLT bots tell me it's slower I'll fix to do just that.

Thanks!
Comment 4 WebKit Commit Bot 2011-03-30 08:24:23 PDT
Comment on attachment 87484 [details]
Patch

Rejecting attachment 87484 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'apply-..." exit_code: 2

Last 500 characters of output:
s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/rendering/RenderBlock.h
patching file Source/WebCore/rendering/RenderBlockLineLayout.cpp
Hunk #1 FAILED at 608.
Hunk #2 succeeded at 853 (offset 21 lines).
1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/rendering/RenderBlockLineLayout.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Dan Bernstein', u'--fo..." exit_code: 1

Full output: http://queues.webkit.org/results/8298330
Comment 5 Eric Seidel 2011-04-03 00:29:30 PDT
Created attachment 88001 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2011-04-03 01:30:00 PDT
Comment on attachment 88001 [details]
Patch for landing

Clearing flags on attachment: 88001

Committed r82792: <http://trac.webkit.org/changeset/82792>
Comment 7 WebKit Commit Bot 2011-04-03 01:30:05 PDT
All reviewed patches have been landed.  Closing bug.