Bug 57425

Summary: make webkit-patch upload respect -d
Product: WebKit Reporter: Maciej Stachowiak <mjs>
Component: New BugsAssignee: Maciej Stachowiak <mjs>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch abarth: review+

Maciej Stachowiak
Reported 2011-03-29 23:45:10 PDT
make webkit-patch upload respect -d
Attachments
Patch (1.10 KB, patch)
2011-03-29 23:45 PDT, Maciej Stachowiak 		no flags
DetailsFormatted DiffDiff
Patch (3.48 KB, patch)
2011-03-30 00:46 PDT, Maciej Stachowiak 		abarth: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Maciej Stachowiak
Comment 1 2011-03-29 23:45:28 PDT
Created attachment 87470 [details] Patch
Maciej Stachowiak
Comment 2 2011-03-30 00:46:42 PDT
Created attachment 87478 [details] Patch
Adam Barth
Comment 3 2011-03-30 00:55:05 PDT
Comment on attachment 87478 [details] Patch This looks correct. Ideally we would add a test as well.
Maciej Stachowiak
Comment 4 2011-03-30 00:56:25 PDT
Committed r82407: <http://trac.webkit.org/changeset/82407>
Eric Seidel (no email)
Comment 5 2011-03-30 01:04:01 PDT
Be strong abarth! /me is very sad at lack of testing. :(
Maciej Stachowiak
Comment 6 2011-03-30 01:05:14 PDT
I will learn how to operate the Python unit tests some day. scm_unitests.py boggles my mind at present.
Eric Seidel (no email)
Comment 7 2011-03-30 01:08:23 PDT
scm_unitteset.py is our oldest and worst unit test file. But you can run a single class of tests with: test-webkitpy webkitpy.common.checkout.scm_unittest.SCMClassTests or even just a single test: test-webkitpy webkitpy.common.checkout.scm_unittest.SCMClassTests.test_run_command_with_pipe
Note You need to log in before you can comment on or make changes to this bug.