Bug 57410

Summary: new-run-webkit-tests: use 'threads' on win instead of 'old-threads'
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aroben, mihaip, ojan, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on: 57417    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Dirk Pranke
Reported 2011-03-29 17:42:30 PDT
new-run-webkit-tests: use 'threads' on win instead of 'old-threads'
Attachments
Patch (3.11 KB, patch)
2011-03-29 17:43 PDT, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2011-03-29 17:43:55 PDT
Created attachment 87443 [details] Patch
Dirk Pranke
Comment 2 2011-03-29 17:46:40 PDT
note that bug 55163 is tracking the switch to processes. Theoretically processes should be better than threads, even on windows, because we won't be gated by the python global lock. However, it may be that running IPC in python under multiprocessing may just be too unstable to be reliable. I'd like to test this in the meantime to see how much of the issues on win are issues with the new code structure and messaging vs. the multiple processes issue.
Dirk Pranke
Comment 3 2011-03-29 19:17:27 PDT
Comment on attachment 87443 [details] Patch Clearing flags on attachment: 87443 Committed r82383: <http://trac.webkit.org/changeset/82383>
Dirk Pranke
Comment 4 2011-03-29 19:17:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.