Bug 57408 – -webkit-min-device-pixel-ratio media query doesn't work post-SnowLeopard

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Beth Dakin]

Post-SnowLeopard, typing "javascript:alert(window.devicePixelRatio)" into the URL field always returns 1 regardless of the actual device pixel ratio.

<rdar://problem/8665411>

[Beth Dakin]

Created attachment 87445 [details]
Patch

The new and the old APIs are implemented on both NSWindow and NSScreen. The call sites that used to have to nil-check NSWindow now just default to NSScreen.

[WebKit Review Bot]

Attachment 87445 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebKit2/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Source/WebKit/mac/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 3 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Beth Dakin]

Created attachment 87447 [details]
New patch

[Beth Dakin]

(In reply to comment #2)
> Attachment 87445 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
> 
> Source/WebKit2/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
> Source/WebKit/mac/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
> Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
> Total errors found: 3 in 19 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

You lie style bot. You lie.

[WebKit Review Bot]

Attachment 87447 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebKit2/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Source/WebKit/mac/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 3 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Beth Dakin]

(In reply to comment #5)
> Attachment 87447 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
> 
> Source/WebKit2/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
> Source/WebKit/mac/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
> Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
> Total errors found: 3 in 19 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

Whatevs. Known liar.

[Darin Adler]

Comment on attachment 87447 [details]
New patch

I’d probably use 72 instead of 72.0 in all those places. If this really is the best practice, then lets land this. I’m kind of surprised, though, because I’d think that we might want a different value if the HI scale factor of the window the view is being displayed in was 2X.

[Beth Dakin]

Created attachment 87469 [details]
Way cooler patch

Thanks for the review Darin, but I take it back! deviceDescription is so two weeks ago. backingScaleFactor is all the rage these days.

[WebKit Review Bot]

Attachment 87469 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebKit2/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Source/WebKit/mac/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 3 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Beth Dakin]

(In reply to comment #9)
> Attachment 87469 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
> 
> Source/WebKit2/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
> Source/WebKit/mac/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
> Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
> Total errors found: 3 in 19 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

Oh shush, you.

[Maciej Stachowiak]

Comment on attachment 87469 [details]
Way cooler patch

r=me

Style checker's lies are probably because the usual style is to put the bugzilla number on a separate line after the bug title. Suggest making that change.

[Beth Dakin]

(In reply to comment #11)
> (From update of attachment 87469 [details])
> r=me
> 
> Style checker's lies are probably because the usual style is to put the bugzilla number on a separate line after the bug title. Suggest making that change.

Thanks Maciej! I begrudgingly submit my ChangeLog individuality to the style bot overlords. 

Committed with revision 82398.

[Eric Seidel (no email)]

Comment on attachment 87447 [details]
New patch

Cleared Darin Adler's review+ from obsolete attachment 87447 [details] so that this bug does not appear in http://webkit.org/pending-commit.