Bug 57406

Summary: Add default localization strategy that can be shared by WebKit1 and WebKit2
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch andersca: review+

Sam Weinig
Reported 2011-03-29 17:29:41 PDT
Add default localization strategy that can be shared by WebKit1 and WebKit2
Attachments
Patch (149.88 KB, patch)
2011-03-29 17:43 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (150.67 KB, patch)
2011-03-30 10:16 PDT, Sam Weinig 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2011-03-29 17:43:40 PDT
Created attachment 87442 [details] Patch
WebKit Review Bot
Comment 2 2011-03-29 17:47:24 PDT
Attachment 87442 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/Android.mk', u'Source/WebCo..." exit_code: 1 Source/WebKit2/ChangeLog:28: ChangeLog entry has no bug number [changelog/bugnumber] [5] Source/WebCore/platform/DefaultLocalizationStrategy.h:168: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 3 2011-03-30 10:16:37 PDT
Created attachment 87560 [details] Patch
Sam Weinig
Comment 4 2011-03-30 10:29:07 PDT
Landed in r82465.
Note You need to log in before you can comment on or make changes to this bug.