Bug 57397

Summary:

ShareableBitmap needs its own Handle type

Product:

WebKit

Reporter:

Adam Roben (:aroben) <aroben>

Component:

New Bugs

Assignee:

Adam Roben (:aroben) <aroben>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

57388

Attachments:

Description	Flags
Patch	andersca: review+

Description Adam Roben (:aroben) 2011-03-29 16:01:10 PDT

ShareableBitmap needs its own Handle type

Comment 1 Adam Roben (:aroben) 2011-03-29 16:01:53 PDT

Created attachment 87424 [details]
Patch

Comment 2 WebKit Review Bot 2011-03-29 16:04:49 PDT

Attachment 87424 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Adam Roben (:aroben) 2011-03-29 16:11:45 PDT

Comment on attachment 87424 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=87424&action=review

>> Source/WebKit2/ChangeLog:1
>> +2011-03-29  Adam Roben  <aroben@apple.com>
> 
> ChangeLog entry has no bug number  [changelog/bugnumber] [5]

I guess check-webkit-style doesn't like my non-standard way of including bug URLs in ChangeLogs.

Comment 4 Adam Roben (:aroben) 2011-03-30 07:43:28 PDT

Committed r82441: <http://trac.webkit.org/changeset/82441>