Bug 57352

Summary: Style Checker should prevent enums in bitfields
Product: WebKit Reporter: Levi Weintraub <leviw>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: brian.holt, commit-queue, dpranke, eric, glenn, levin, leviw, mrobinson, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
URL: http://rogerkarlsson.com/blogs/programming/enum-bit-field-visual-studio/
Attachments:
Description Flags
Patch none

Levi Weintraub
Reported 2011-03-29 09:41:34 PDT
MSVC 8.0 has a bug where enums in bitfields are treated as signed, which causes the value when you read them back out to be incorrect (see description in link). The style checker should prevent us from falling in this hole like I almost did.
Attachments
Patch (4.06 KB, patch)
2013-07-16 08:39 PDT, Brian Holt 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2011-03-29 09:46:09 PDT
We (somewhat famously) hit this bug early during the Safari Win bringup. Folks continue to hit it today. Making check-webkit-style catch it would be nifty.
David Levin
Comment 2 2011-03-29 10:20:27 PDT
fwiw, the code is here: http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py And I'm willing to give pointers (and reviews) to anyone who wants to add checks.
Brian Holt
Comment 3 2013-07-16 08:39:06 PDT
Created attachment 206786 [details] Patch
Brian Holt
Comment 4 2013-08-29 08:20:47 PDT
Any thoughts on the patch? David would you be interested in reviewing it?
Darin Adler
Comment 5 2014-07-12 16:59:00 PDT
Comment on attachment 206786 [details] Patch Looks OK.
WebKit Commit Bot
Comment 6 2014-07-12 17:31:35 PDT
Comment on attachment 206786 [details] Patch Clearing flags on attachment: 206786 Committed r171038: <http://trac.webkit.org/changeset/171038>
WebKit Commit Bot
Comment 7 2014-07-12 17:31:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.