Summary: | Style Checker should prevent enums in bitfields | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Levi Weintraub <leviw> | ||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | brian.holt, commit-queue, dpranke, eric, glenn, levin, leviw, mrobinson, rniwa | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Windows XP | ||||||
URL: | http://rogerkarlsson.com/blogs/programming/enum-bit-field-visual-studio/ | ||||||
Attachments: |
|
Description
Levi Weintraub
2011-03-29 09:41:34 PDT
We (somewhat famously) hit this bug early during the Safari Win bringup. Folks continue to hit it today. Making check-webkit-style catch it would be nifty. fwiw, the code is here: http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py And I'm willing to give pointers (and reviews) to anyone who wants to add checks. Created attachment 206786 [details]
Patch
Any thoughts on the patch? David would you be interested in reviewing it? Comment on attachment 206786 [details]
Patch
Looks OK.
Comment on attachment 206786 [details] Patch Clearing flags on attachment: 206786 Committed r171038: <http://trac.webkit.org/changeset/171038> All reviewed patches have been landed. Closing bug. |