Bug 57329

Summary: Web Inspector: InspectorDOMAgent has unnecessary dependency from InspectorAgent
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, apavlov, bweinstein, eric, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[patch] initial version
none
[patch] second version. Assert in inspect() was changed to if. none

Ilya Tikhonovsky
Reported 2011-03-29 05:14:26 PDT
%subj% It was introduced at r81771.
Attachments
[patch] initial version (10.90 KB, patch)
2011-03-29 05:18 PDT, Ilya Tikhonovsky 		no flags
DetailsFormatted DiffDiff
[patch] second version. Assert in inspect() was changed to if. (10.91 KB, patch)
2011-03-29 06:16 PDT, Ilya Tikhonovsky 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2011-03-29 05:18:18 PDT
Created attachment 87300 [details] [patch] initial version
Ilya Tikhonovsky
Comment 2 2011-03-29 06:16:40 PDT
Created attachment 87304 [details] [patch] second version. Assert in inspect() was changed to if.
Yury Semikhatsky
Comment 3 2011-03-29 07:28:03 PDT
Comment on attachment 87304 [details] [patch] second version. Assert in inspect() was changed to if. View in context: https://bugs.webkit.org/attachment.cgi?id=87304&action=review > Source/WebCore/inspector/InspectorDOMAgent.h:163 > + void focusNode(); This one should be private.
Ilya Tikhonovsky
Comment 4 2011-03-29 09:13:56 PDT
Landed r82263
WebKit Review Bot
Comment 5 2011-03-29 10:58:02 PDT
http://trac.webkit.org/changeset/82263 might have broken GTK Linux 32-bit Release The following tests are not passing: fast/loader/onload-willSendRequest-null-for-frame.html
Note You need to log in before you can comment on or make changes to this bug.