Bug 57325

Summary: [GTK] http/tests/uri/username-with-no-hostname.html fails
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, mrobinson, svillar, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
proposed patch mrobinson: review+

Description Philippe Normand 2011-03-29 03:40:30 PDT
--- /home/slave/webkitgtk/gtk-linux-64-debug/build/layout-test-results/http/tests/uri/username-with-no-hostname-expected.txt	2011-03-29 02:40:26.817906132 -0700
+++ /home/slave/webkitgtk/gtk-linux-64-debug/build/layout-test-results/http/tests/uri/username-with-no-hostname-actual.txt	2011-03-29 02:40:26.805911530 -0700
@@ -1,4 +1,3 @@
-Blocked access to external URL http://user@/localhost:8000/misc/resources/compass.jpg
 This test checks that URLs with a username but no hostname do not mistakenly get loaded. If it fails in the browser, you will also see an image.
 PASS document.getElementsByTagName("img")[0].width is 0
 

I have a patch for this issue. Will skip the test for now and wait the review :)
Comment 1 Philippe Normand 2011-03-29 03:46:30 PDT
Created attachment 87294 [details]
proposed patch
Comment 2 Philippe Normand 2011-03-29 03:46:57 PDT
Skipped in http://trac.webkit.org/changeset/82224
Comment 3 Philippe Normand 2011-03-29 09:39:39 PDT
Committed r82267: <http://trac.webkit.org/changeset/82267>
Comment 4 Philippe Normand 2011-03-29 10:13:37 PDT
And follow-up http://trac.webkit.org/changeset/82271 to fix

http/tests/security/host-compare-case-insensitive.html and  
http/tests/xmlhttprequest/origin-whitelisting-exact-match.html
Comment 5 WebKit Review Bot 2011-03-29 10:58:15 PDT
http://trac.webkit.org/changeset/82267 might have broken GTK Linux 32-bit Release
The following tests are not passing:
fast/loader/onload-willSendRequest-null-for-frame.html
Comment 6 Philippe Normand 2011-03-29 11:01:09 PDT
(In reply to comment #5)
> http://trac.webkit.org/changeset/82267 might have broken GTK Linux 32-bit Release
> The following tests are not passing:
> fast/loader/onload-willSendRequest-null-for-frame.html

See bug 57362