Bug 57314

Summary: [Qt] Add -print-loaded-urls option to Qt's MiniBrowser and to QtTestBrowser
Product: WebKit Reporter: Zoltan Horvath <zoltan>
Component: Tools / TestsAssignee: Zoltan Horvath <zoltan>
Status: RESOLVED FIXED    
Severity: Normal Keywords: Qt
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
proposed patch
kling: review-
proposed patch kling: review+

Zoltan Horvath
Reported 2011-03-29 01:44:48 PDT
Provide possibility to print loaded urls to the standard output.
Attachments
proposed patch (6.56 KB, patch)
2011-03-29 01:46 PDT, Zoltan Horvath 		kling: review-
DetailsFormatted DiffDiff
proposed patch (6.58 KB, patch)
2011-03-29 06:16 PDT, Zoltan Horvath 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zoltan Horvath
Comment 1 2011-03-29 01:46:28 PDT
Created attachment 87282 [details] proposed patch
Andreas Kling
Comment 2 2011-03-29 06:15:45 PDT
Comment on attachment 87282 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=87282&action=review r-, comments on irc > Tools/MiniBrowser/qt/BrowserWindow.cpp:65 > + if (m_windowOptions.printLoadedUrls) > + connect(page(), SIGNAL(urlChanged(const QUrl&)), this, SLOT(printURL())); We typically normalize signal/slot names so Qt doesn't have to do it for us. "urlChanged(const QUrl&)" -> "urlChanged(QUrl)" printURL() should take the const QUrl& argument and print that instead of fetching it from the view.
Zoltan Horvath
Comment 3 2011-03-29 06:16:23 PDT
Created attachment 87303 [details] proposed patch
Zoltan Horvath
Comment 4 2011-03-29 06:16:49 PDT
Comment on attachment 87303 [details] proposed patch Thanks for the comments.
Andreas Kling
Comment 5 2011-03-29 06:20:18 PDT
Comment on attachment 87303 [details] proposed patch Shazam!
Zoltan Horvath
Comment 6 2011-03-29 06:37:40 PDT
Thank you! Landed in r82244. http://trac.webkit.org/changeset/82244
Note You need to log in before you can comment on or make changes to this bug.