Bug 57288

Summary: Move libtess from WebCore/thirdparty to ThirdParty
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: kbr
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
work in progress
none
patch kbr: review+

Description Adam Barth 2011-03-28 17:25:37 PDT
Move libtess from WebCore/thirdparty to ThirdParty
Comment 1 Adam Barth 2011-03-28 17:28:34 PDT
Created attachment 87243 [details]
work in progress
Comment 2 Adam Barth 2011-03-28 17:29:18 PDT
@kbr: Thoughts on execution?  I wasn't sure whether to trim "ThirdParty" from the include path...
Comment 3 Adam Barth 2011-03-28 18:25:46 PDT
Created attachment 87247 [details]
patch
Comment 4 Adam Barth 2011-03-28 18:28:39 PDT
Comment on attachment 87247 [details]
patch

Marking for review b/c it builds locally.
Comment 5 Kenneth Russell 2011-03-29 12:02:14 PDT
Comment on attachment 87247 [details]
patch

Thanks for moving and cleaning this up. It basically looks fine. There are some files which aren't showing up in the patch such as LICENSE.txt and GNUmakefile. I assume that these files do exist in the new directory and that they're just not showing up in the patch because there were no changes to the content. As long as you manually verify that all of the files exist in the new directory it looks good to me.