Summary: | WebKit2 bundle page needs to offer generated file hooks | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Darin Adler <darin> | ||||||
Component: | WebKit2 | Assignee: | Darin Adler <darin> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ossy, webkit-ews | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Other | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Darin Adler
2011-03-28 15:30:07 PDT
Created attachment 87221 [details]
Patch
Attachment 87221 [details] did not build on qt: Build output: http://queues.webkit.org/results/8273522 Comment on attachment 87221 [details]
Patch
Forgot to include the WebKitTestRunner part of the patch. Uploading a copy with that in it soon.
Created attachment 87245 [details]
Patch
Comment on attachment 87245 [details]
Patch
Presumably the two MiniBrowser implementations need to be updated as well.
(In reply to comment #5) > Presumably the two MiniBrowser implementations need to be updated as well. I’ll check. But maybe not if they don’t have a UI client at all. I searched for the name of the struct I changed in the entire tree and did not get any hits on MiniBrowser. Committed r82289: <http://trac.webkit.org/changeset/82289> (In reply to comment #7) > Committed r82289: <http://trac.webkit.org/changeset/82289> It broke WTR build because of missing initializers for members: /home/oszi/WebKit/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: In constructor ‘WTR::InjectedBundlePage::InjectedBundlePage(const OpaqueWKBundlePage*)’: /home/oszi/WebKit/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:216: error: missing initializer for member ‘WKBundlePageUIClient::shouldGenerateFileForUpload’ /home/oszi/WebKit/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:216: error: missing initializer for member ‘WKBundlePageUIClient::generateFileForUpload’ I landed the missing part of the patch: http://trac.webkit.org/changeset/82302 Sorry about not landing that part! I am not sure why webkit-patch didn’t land it. Last time I had this problem, someone told me it was due to Maciej’s changes to work only within a certain directory, and I can’t prove that didn’t happen this time, but I don’t think it did. |