Bug 57271
Summary: | Min width at which video controls hide buttons changed | ||
---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> |
Component: | Media | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED INVALID | ||
Severity: | Normal | CC: | dglazkov, jer.noble, simon.fraser |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | Mac | ||
OS: | OS X 10.5 |
Simon Fraser (smfr)
At some point the min <video> width at which the controls hide some of the buttons changed. It used to be around 240px, and now it's about 263px.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Dimitri Glazkov (Google)
I did that!
The comment around the logic of controls was implying that we want to have a minimum width of the timeline at 100px, but the the logic was fudged up and it was less than that. Now it should switch exactly at 100px.
Dimitri Glazkov (Google)
Here's the line I mentioned: http://google.com/codesearch/p#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/rendering/MediaControlElements.cpp&l=969&exact_package=chromium
Simon Fraser (smfr)
OK.