Summary: | getComputedStyle counterIncrement crash @ WebCore::counterToCSSValue | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Emil A Eklund <eae> | ||||||||
Component: | DOM | Assignee: | Emil A Eklund <eae> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Emil A Eklund
2011-03-28 14:25:47 PDT
This is a NULL pointer crash in WebCore::counterToCSSValue. Created attachment 87205 [details]
Test case
Created attachment 87206 [details]
Patch
Comment on attachment 87206 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=87206&action=review > Source/WebCore/css/CSSComputedStyleDeclaration.cpp:775 > + return NULL; We use 0, not NULL, in the WebKit project. Attachment 87206 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1
Source/WebCore/css/CSSComputedStyleDeclaration.cpp:775: Use 0 instead of NULL. [readability/null] [5]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 87209 [details]
Patch
Of course, my bad. Old habit, takes some time to retrain.
Comment on attachment 87209 [details] Patch Clearing flags on attachment: 87209 Committed r82222: <http://trac.webkit.org/changeset/82222> All reviewed patches have been landed. Closing bug. |