Bug 57263

Summary:

CGImageRefs must hold a strong reference to underlying data

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	sam: review+

Anders Carlsson

Reported 2011-03-28 13:29:18 PDT

CGImageRefs must hold a strong reference to underlying data

Attachments
Patch (11.80 KB, patch) 2011-03-28 13:32 PDT, Anders Carlsson	sam: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Anders Carlsson

Comment 1 2011-03-28 13:32:59 PDT

Created attachment 87191 [details] Patch

Sam Weinig

Comment 2 2011-03-28 13:35:51 PDT

Comment on attachment 87191 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=87191&action=review > Source/WebKit2/Shared/cg/ShareableBitmapCG.cpp:58 > +RetainPtr<CGImageRef> ShareableBitmap::createCGImageCopy() Lets call this makeCGImage. > Source/WebKit2/Shared/cg/ShareableBitmapCG.cpp:65 > +RetainPtr<CGImageRef> ShareableBitmap::createCGImage() This one too.

Anders Carlsson

Comment 3 2011-03-28 13:46:04 PDT

Committed r82151: <http://trac.webkit.org/changeset/82151>

WebKit Review Bot

Comment 4 2011-03-28 13:58:58 PDT

http://trac.webkit.org/changeset/82151 might have broken Windows Release (Build) and Windows Debug (Build)

Note You need to log in before you can comment on or make changes to this bug.