Bug 57257
| Summary: | Use willCacheResponse on Windows instead of shouldCacheResponse | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Pratik Solanki <psolanki> |
| Component: | Platform | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | ap, darin, jberlin, mitz |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | OS X 10.5 | ||
Pratik Solanki
ResourceLoader.h has two different callback methods.
On Mac - virtual NSCachedURLResponse* willCacheResponse(ResourceHandle*, NSCachedURLResponse*);
On Windows - virtual bool shouldCacheResponse(ResourceHandle*, CFCachedURLResponseRef);
The method on Windows should match the one on Mac. It should be
virtual CFCachedURLResponseRef willCacheResponse(ResourceHandle*, CFCachedURLResponseRef);
I am adding the above method for Mac when using CFNetwork (see bug 51836). Windows code should use that.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |