Bug 57256

Summary: Fix crash on Solaris 10 for misaligned reads on Sparc processors
Product: WebKit Reporter: Ben Taylor <bentaylor.solx86>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ademar, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Other   
Attachments:
Description Flags
Proposed patch which compiles correctly in qt-4.7.2 with webkit enabled on Solaris 10 with SS12 C++ compiler none

Ben Taylor
Reported 2011-03-28 11:49:09 PDT
Sparc cannot do 32-bit reads on misaligned boundaries. The program crashes if you try to do so. t@1 (l@1) signal BUS (invalid address alignment) in WebCore::equal at 0xffffffff7e2719fc 0xffffffff7e2719fc: equal+0x002c: ld [%o1], %g1 (originally reported from https://bugs.webkit.org/show_bug.cgi?id=24932 by Thiago Macieria, patch 05/17)
Attachments
Proposed patch which compiles correctly in qt-4.7.2 with webkit enabled on Solaris 10 with SS12 C++ compiler (1.30 KB, patch)
2011-03-28 13:15 PDT, Ben Taylor 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ben Taylor
Comment 1 2011-03-28 13:15:34 PDT
Created attachment 87185 [details] Proposed patch which compiles correctly in qt-4.7.2 with webkit enabled on Solaris 10 with SS12 C++ compiler Fix crash on misaligned reads on Solaris 10/Sparc. Original bug reported and proposed fix by Thiago Macieria in bug https://bugs.webkit.org/show_bug.cgi?id=24932
WebKit Commit Bot
Comment 2 2011-03-29 00:59:37 PDT
Comment on attachment 87185 [details] Proposed patch which compiles correctly in qt-4.7.2 with webkit enabled on Solaris 10 with SS12 C++ compiler Clearing flags on attachment: 87185 Committed r82207: <http://trac.webkit.org/changeset/82207>
WebKit Commit Bot
Comment 3 2011-03-29 00:59:40 PDT
All reviewed patches have been landed. Closing bug.
Ademar Reis
Comment 4 2011-06-03 07:19:30 PDT
Looks like the patch attached to this bug was incomplete. See bug 29407, I attached a patch there with the missing checks.
Note You need to log in before you can comment on or make changes to this bug.