Bug 57255

Summary: [chromium] have DRT write the png checksum into a png comment
Product: WebKit Reporter: Tony Chang <tony>
Component: New BugsAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: ojan, tkent
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 56286    
Attachments:
Description Flags
Patch abarth: review+, abarth: commit-queue-

Tony Chang
Reported 2011-03-28 11:45:52 PDT
[chromium] have DRT write the png checksum into a png comment
Attachments
Patch (2.90 KB, patch)
2011-03-28 11:46 PDT, Tony Chang 		abarth: review+
abarth: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2011-03-28 11:46:49 PDT
Created attachment 87175 [details] Patch
Tony Chang
Comment 2 2011-03-28 11:48:38 PDT
There will be follow up changes for NRWT and the rebaseline tool.
Adam Barth
Comment 3 2011-03-28 16:26:11 PDT
Comment on attachment 87175 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=87175&action=review > Tools/DumpRenderTree/chromium/TestShell.cpp:561 > - static_cast<int>(sourceBitmap.rowBytes()), discardTransparency, &png); > + static_cast<int>(sourceBitmap.rowBytes()), discardTransparency, > + md5hash, &png); This should be on one line.
Tony Chang
Comment 4 2011-03-28 16:49:18 PDT
Committed r82174: <http://trac.webkit.org/changeset/82174>
Note You need to log in before you can comment on or make changes to this bug.