MediaPlayerPrivateAVFoundation should report that it supportsFullScreen()

• Component: Media
• Status: RESOLVED FIXED

[Jer Noble]

With the FULLSCREEN_API changes, media players need not do anything special to support full screen; so when it is enabled, AVFoundation should return true for supportsFullScreen().

[Jer Noble]

<rdar://problem/9197629>

[Jer Noble]

Created attachment 87189 [details]
Patch

[Darin Adler]

Comment on attachment 87189 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=87189&action=review

> Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:393
> +    // FIXME: WebVideoFullscreenController assumes a QTKit/QuickTime media engine

I don’t understand this FIXME.

[Jer Noble]

Created attachment 87190 [details]
Patch

Now with 200% more ChangeLogs\!

[Jer Noble]

Comment on attachment 87189 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=87189&action=review

>> Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:393
>> +    // FIXME: WebVideoFullscreenController assumes a QTKit/QuickTime media engine
> 
> I don’t understand this FIXME.

I moved the FIXME here from the header.  Our previous full screen implementation (WebVideoFullscreenController) relies on QTKit, as a single QTMovie can drive multiple QTMovieLayers.  But this means the implementation is specific to a QTKit-backed MediaPlayer.  If FULLSCREEN_API is not enabled, it would be unsafe to return "true" here without addressing the underlying assumptions made by WebVideoFullscreenController.

[Jer Noble]

Committed r82167: <http://trac.webkit.org/changeset/82167>