Bug 57249

Summary: MediaPlayerPrivateAVFoundation should report that it supportsFullScreen()
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: MediaAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.6   
Attachments:
Description Flags
Patch
none
Patch darin: review+

Jer Noble
Reported 2011-03-28 10:42:55 PDT
With the FULLSCREEN_API changes, media players need not do anything special to support full screen; so when it is enabled, AVFoundation should return true for supportsFullScreen().
Attachments
Patch (12.50 KB, patch)
2011-03-28 13:25 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (14.30 KB, patch)
2011-03-28 13:26 PDT, Jer Noble 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2011-03-28 12:01:54 PDT
<rdar://problem/9197629>
Jer Noble
Comment 2 2011-03-28 13:25:31 PDT
Created attachment 87189 [details] Patch
Darin Adler
Comment 3 2011-03-28 13:26:28 PDT
Comment on attachment 87189 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=87189&action=review > Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:393 > + // FIXME: WebVideoFullscreenController assumes a QTKit/QuickTime media engine I don’t understand this FIXME.
Jer Noble
Comment 4 2011-03-28 13:26:55 PDT
Created attachment 87190 [details] Patch Now with 200% more ChangeLogs\!
Jer Noble
Comment 5 2011-03-28 13:34:20 PDT
Comment on attachment 87189 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=87189&action=review >> Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:393 >> + // FIXME: WebVideoFullscreenController assumes a QTKit/QuickTime media engine > > I don’t understand this FIXME. I moved the FIXME here from the header. Our previous full screen implementation (WebVideoFullscreenController) relies on QTKit, as a single QTMovie can drive multiple QTMovieLayers. But this means the implementation is specific to a QTKit-backed MediaPlayer. If FULLSCREEN_API is not enabled, it would be unsafe to return "true" here without addressing the underlying assumptions made by WebVideoFullscreenController.
Jer Noble
Comment 6 2011-03-28 15:31:59 PDT
Committed r82167: <http://trac.webkit.org/changeset/82167>
Note You need to log in before you can comment on or make changes to this bug.