Bug 57240

Summary: Web Inspector: brush up and rename debugger domain.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aandrey, abarth, apavlov, bweinstein, dglazkov, eric, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch yurys: review+

Description Pavel Feldman 2011-03-28 09:33:32 PDT 
Patch to follow.
Comment 1 Pavel Feldman 2011-03-28 09:49:50 PDT 
Created attachment 87155 [details]
Patch
Comment 2 WebKit Review Bot 2011-03-28 09:58:22 PDT 
Attachment 87155 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8272553
Comment 3 Yury Semikhatsky 2011-03-28 09:58:31 PDT 
Comment on attachment 87155 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=87155&action=review

> Source/WebCore/inspector/Inspector.json:1228
> +                "name": "scriptFailedToParse",

scriptParsingFailed

> Source/WebCore/inspector/InspectorDebuggerAgent.cpp:181
> +void InspectorDebuggerAgent::setBreakpoint(ErrorString*, const String& sourceId, int lineNumber, int columnNumber, const String& condition, bool enabled, String* outBreakpointId, int* actualLineNumber, int* actualColumnNumber)

setBreakpointBySourceId?
Comment 4 Pavel Feldman 2011-03-28 10:17:21 PDT 
Committed r82131: <http://trac.webkit.org/changeset/82131>
Comment 5 WebKit Review Bot 2011-03-28 10:24:26 PDT 
http://trac.webkit.org/changeset/82131 might have broken Chromium Linux Release
Comment 6 Andrey Adaikin 2011-03-30 02:35:08 PDT 
View in context: https://bugs.webkit.org/attachment.cgi?id=87155&action=review

> Source/WebCore/inspector/front-end/DebuggerModel.js:182
> +    _didEditScriptSource: function(sourceID, callback, error, error, newBody, callFrames)

ERROR: redefinition of "error" variable. It breaks handling JS backend compile errors in live edit.