Bug 57233

Summary: move directionOfEnclosingBlock() to be global so that it could be reused
Product: WebKit Reporter: Xiaomei Ji <xji>
Component: HTML EditingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 25298    
Attachments:
Description Flags
patch
rniwa: review-
patch rniwa: review+

Xiaomei Ji
Reported 2011-03-28 07:47:24 PDT
we should provide a directionOfEnclosingBlock(Node*) so that it could be reused in SelectionController and other functions in visible_units.cpp, such as moving caret by word in visual order (which needs to know the direction of box and enclosing block, and the caret movement direction).
Attachments
patch (3.96 KB, patch)
2011-03-28 08:19 PDT, Xiaomei Ji
rniwa: review-
patch (3.99 KB, patch)
2011-03-28 08:44 PDT, Xiaomei Ji
rniwa: review+
Xiaomei Ji
Comment 1 2011-03-28 08:19:55 PDT
Ryosuke Niwa
Comment 2 2011-03-28 08:27:25 PDT
Comment on attachment 87147 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=87147&action=review > Source/WebCore/editing/SelectionController.cpp:339 > + return WebCore::directionOfEnclosingBlock(m_selection.extent().anchorNode()); This isn't right. You're calling anchorNode() here even though the original code called containerNode().
Xiaomei Ji
Comment 3 2011-03-28 08:44:54 PDT
Ryosuke Niwa
Comment 4 2011-03-28 08:51:33 PDT
Comment on attachment 87149 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=87149&action=review > Source/WebCore/ChangeLog:8 > + Provide global function directionOfEnclosingBlock(Node*) so that it could be > + reused in SelectionController and other functionalities that need enclosing > + block's direcionality, such as moving caret by word in visual order. > + https://bugs.webkit.org/show_bug.cgi?id=57233. This isn't really a standard way of writing a change long entry. Please do: move directionOfEnclosingBlock() to be global so that it could be reused https://bugs.webkit.org/show_bug.cgi?id=57233 Provide global function directionOfEnclosingBlock(Node*) so that it could be reused in SelectionController and other functionalities that need enclosing block's direcionality, such as moving caret by word in visual order.
Xiaomei Ji
Comment 5 2011-03-28 08:56:41 PDT
Note You need to log in before you can comment on or make changes to this bug.