Bug 57229

Summary: Web Inspector: execution line is displayed incorrectly after source editing.
Product: WebKit Reporter: Pavel Podivilov <podivilov>
Component: Web Inspector (Deprecated)Assignee: Andrey Adaikin <aandrey>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Pavel Podivilov
Reported 2011-03-28 06:18:28 PDT
Web Inspector: execution line is displayed incorrectly after source editing. 1. Pause on a breakpoint 2. Edit source above the execution line 3. Editor execution line decoration is moved while gutter decoration is not.
Attachments
Patch (4.32 KB, patch)
2011-03-29 08:04 PDT, Andrey Adaikin 		no flags
DetailsFormatted DiffDiff
Patch (8.98 KB, patch)
2011-03-30 02:42 PDT, Andrey Adaikin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andrey Adaikin
Comment 1 2011-03-29 08:04:12 PDT
Created attachment 87331 [details] Patch
Pavel Feldman
Comment 2 2011-03-29 08:37:54 PDT
Comment on attachment 87331 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=87331&action=review > Source/WebCore/inspector/front-end/SourceFrame.js:188 > + if (this._executionLineNumber !== undefined) { I often use typeof this._executionLineNumber === "number" in such cases
Andrey Adaikin
Comment 3 2011-03-30 02:39:19 PDT
Comment on attachment 87331 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=87331&action=review >> Source/WebCore/inspector/front-end/SourceFrame.js:188 >> + if (this._executionLineNumber !== undefined) { > > I often use typeof this._executionLineNumber === "number" in such cases done
Andrey Adaikin
Comment 4 2011-03-30 02:42:52 PDT
Created attachment 87489 [details] Patch
Pavel Podivilov
Comment 5 2011-03-31 04:31:28 PDT
Comment on attachment 87489 [details] Patch Clearing flags on attachment: 87489 Committed r82560: <http://trac.webkit.org/changeset/82560>
Pavel Podivilov
Comment 6 2011-03-31 04:31:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.