Bug 57186

Summary:

Web Inspector: refactor ResourceTreeModel to remove poor dependencies.

Product:

WebKit

Reporter:

Pavel Feldman <pfeldman>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, apavlov, bweinstein, eric, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
[PATCH] Same with more informative changelog.	yurys: review+

Pavel Feldman

Reported 2011-03-27 10:39:49 PDT

Here is the list of what has been done: - ResourceTreeModel is now event target (Object) - There is no ResourceTreeModel -> UI dependencies - NetworkManager -> ResourceTreeModel dependencies has been removed - NetworkManager is no longer dealing with the resources tree, it is only responsible for network events - ResourceTreeModel requests tree structure from the backend separately - Cached resources tree payload is now limited to url and type (no headers involved) - Resources tree is being rendered lazily upon request from the panel.

Attachments
Patch (67.59 KB, patch) 2011-03-27 11:40 PDT, Pavel Feldman	no flags	Details Formatted Diff Diff
[PATCH] Same with more informative changelog. (68.14 KB, patch) 2011-03-27 11:46 PDT, Pavel Feldman	yurys: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Pavel Feldman

Comment 1 2011-03-27 11:40:59 PDT

Created attachment 87080 [details] Patch

Pavel Feldman

Comment 2 2011-03-27 11:46:35 PDT

Created attachment 87081 [details] [PATCH] Same with more informative changelog.

Yury Semikhatsky

Comment 3 2011-03-28 03:24:22 PDT

Comment on attachment 87081 [details] [PATCH] Same with more informative changelog. View in context: https://bugs.webkit.org/attachment.cgi?id=87081&action=review > Source/WebCore/inspector/front-end/ResourceTreeModel.js:62 > + WebInspector.networkManager.addEventListener(WebInspector.NetworkManager.EventTypes.ResourceFinished, this._onResourceUpdated, this); Please call this before getCachedResources. > Source/WebCore/inspector/front-end/ResourceTreeModel.js:80 > + frames: function(parentFrameId) nuke it > Source/WebCore/inspector/front-end/ResourceTreeModel.js:191 > + this._resourcesByURL[resource.url] = resource; _resourcesByURL -> _resourceByURL

Pavel Feldman

Comment 4 2011-03-28 05:18:29 PDT

Committed r82106: <http://trac.webkit.org/changeset/82106>

WebKit Review Bot

Comment 5 2011-03-28 06:07:17 PDT

http://trac.webkit.org/changeset/82106 might have broken Qt Linux Release

Note You need to log in before you can comment on or make changes to this bug.