Bug 57183

Summary: REGRESSION(r54712): [Qt] Installed QtWebKit header does not compile.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Tools / TestsAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, jade.han, jturcotte, laszlo.gombos, ossy, vestbo
Priority: P1 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch (r=benjamin) none

Andreas Kling
Reported 2011-03-27 07:17:45 PDT
The installed <QtWebKit> convenience header contains #include \<QtNetwork/QtNetwork\> which doesn't compile.
Attachments
Patch (r=benjamin) (1.69 KB, patch)
2011-03-27 07:19 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2011-03-27 07:19:44 PDT
Created attachment 87069 [details] Patch (r=benjamin)
Andreas Kling
Comment 2 2011-03-27 07:23:36 PDT
Comment on attachment 87069 [details] Patch (r=benjamin) Clearing flags on attachment: 87069 Committed r82065: <http://trac.webkit.org/changeset/82065>
Andreas Kling
Comment 3 2011-03-27 07:23:44 PDT
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 4 2011-03-27 14:03:18 PDT
(In reply to comment #2) > (From update of attachment 87069 [details]) > Clearing flags on attachment: 87069 > > Committed r82065: <http://trac.webkit.org/changeset/82065> Unfortunately it broke the Symbian build and the Windows build, because Windows' cmd.exe don't like "echo #include <QtNetwork/QtNetwork> >> ..." command. It says >> was unexpected at this time.
Csaba Osztrogonác
Comment 5 2011-03-27 14:34:16 PDT
I have to correct my fail, it works for me on Windows, it seems to be a Symbian related bug. Jade, could you check it, please?
Csaba Osztrogonác
Comment 6 2011-03-28 07:14:22 PDT
Windows fix landed in http://trac.webkit.org/changeset/82113
Note You need to log in before you can comment on or make changes to this bug.