Bug 57182 – implement onerror events for <link rel=prefetch>

• Component: Page Loading
• Status: RESOLVED FIXED

[Gavin Peters]

See Bug 50187 for the implementation of onload events for prefetch, this CL adds onerror support.

[Gavin Peters]

Created attachment 87068 [details]
Patch

[Adam Barth]

Comment on attachment 87068 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=87068&action=review

> Source/WebCore/ChangeLog:22
> +        * html/HTMLLinkElement.cpp:
> +        (WebCore::HTMLLinkElement::parseMappedAttribute):
> +        (WebCore::HTMLLinkElement::onloadTimerFired):
> +        (WebCore::HTMLLinkElement::notifyFinished):
> +        * loader/cache/CachedImage.cpp:
> +        * loader/cache/CachedImage.h:
> +        * loader/cache/CachedResource.cpp:
> +        (WebCore::CachedResource::checkNotify):
> +        (WebCore::CachedResource::data):
> +        (WebCore::CachedResource::error):
> +        * loader/cache/CachedResource.h:
> +        * loader/cache/CachedScript.cpp:
> +        * loader/cache/CachedScript.h:

You should explain why you're making changes to all these different files.  This ChangeLog is calling out for information.  Also, I feel like this patch is the result of a long discussion.  It might be helpful to include some of the reasons why we're making this change in the ChangeLog.  You don't need to write a whole book, but something more than just empty boilerplate is probably a good idea.

[Tony Gentilcore]

> You should explain why you're making changes to all these different files.  This ChangeLog is calling out for information.  Also, I feel like this patch is the result of a long discussion.  It might be helpful to include some of the reasons why we're making this change in the ChangeLog.  You don't need to write a whole book, but something more than just empty boilerplate is probably a good idea.

Patch looks good to me barring Adam's comment about improving the ChangeLog. This is all specced, so you may also want to link there:
http://dev.w3.org/html5/spec/Overview.html#the-link-element

[Gavin Peters]

Created attachment 87187 [details]
Patch

[Gavin Peters]

Created attachment 87188 [details]
Patch

[Gavin Peters]

Thanks for the reviews.  I've significantly filled out the ChangeLog.

[Tony Gentilcore]

Comment on attachment 87188 [details]
Patch

Thanks for the patch.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 87188 [details]:

http/tests/websocket/tests/multiple-connections.html bug 53825 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 87188 [details]
Patch

Clearing flags on attachment: 87188

Committed r82217: <http://trac.webkit.org/changeset/82217>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.