Bug 5717

Summary: REGRESSION: [WebCoreBridge _visiblePositionForPoint:(0,x)] crashes
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: HTML EditingAssignee: Justin Garcia <justin.garcia>
Status: VERIFIED FIXED    
Severity: Major    
Priority: P1    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Bug Depends on:    
Bug Blocks: 5230    
Attachments:
Description Flags
naive fix justin.garcia: review+

Alexey Proskuryakov
Reported 2005-11-12 07:39:24 PST
_visiblePositionForPoint lacks a check for the case when renderer->layer()->hitTest() doesn't find any node. This causes a crash in "run-webkit-tests editing/input/text-input-controller.html" with a fix to bug 5230 being applied. Used to work fine before - apparently, some recent checkin has changed the behavior of hitTest().
Attachments
naive fix (738 bytes, patch)
2005-11-12 07:41 PST, Alexey Proskuryakov 		justin.garcia: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2005-11-12 07:41:25 PST
Created attachment 4674 [details] naive fix I couldn't find the reason why the behavior has changed - but the check for nil seems necessary here nonetheless.
Justin Garcia
Comment 2 2005-11-14 14:19:51 PST
Comment on attachment 4674 [details] naive fix As long as it's correct for hitTest to not find a node in this case, r=me.
Justin Garcia
Comment 3 2005-11-15 11:14:57 PST
Landed
Note You need to log in before you can comment on or make changes to this bug.