Bug 57102

Summary: [Qt] Get rid of the invalid string conversion with ::fromAscii()
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: PlatformAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, benjamin, commit-queue, eric, kling, webkit.review.bot
Priority: P2 Keywords: EasyFix, Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Benjamin Poulain
Reported 2011-03-25 07:07:20 PDT
QString/QChar::fromAscii() is almost never correct inside a library. This call use the default codec, not the ascii one.
Attachments
Patch (3.53 KB, patch)
2011-03-25 07:37 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2011-03-25 07:37:28 PDT
Created attachment 86936 [details] Patch Uploaded manually, webkit-patch exploded in one thousand sparkling pieces for some reason.
Andreas Kling
Comment 2 2011-03-25 07:41:36 PDT
Comment on attachment 86936 [details] Patch em=r
WebKit Commit Bot
Comment 3 2011-03-25 08:02:53 PDT
Comment on attachment 86936 [details] Patch Clearing flags on attachment: 86936 Committed r81961: <http://trac.webkit.org/changeset/81961>
WebKit Commit Bot
Comment 4 2011-03-25 08:02:58 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 5 2011-03-25 09:47:59 PDT
http://trac.webkit.org/changeset/81961 might have broken Windows 7 Release (Tests) The following tests are not passing: http/tests/websocket/tests/frame-length-skip.html
Note You need to log in before you can comment on or make changes to this bug.