Bug 57092

Summary: [Qt] QNetworkReplyHandler refactoring: some adjustments
Product: WebKit Reporter: Luiz Agostini <luiz>
Component: New BugsAssignee: Luiz Agostini <luiz>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, hausmann, jturcotte, kenneth, kling, menard
Priority: P3 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
none
patch
kling: review-
patch kling: review+, kling: commit-queue-

Luiz Agostini
Reported 2011-03-25 01:39:53 PDT
further simplification is possible due to the invariants created by previous patches.
Attachments
patch (8.21 KB, patch)
2011-03-25 01:44 PDT, Luiz Agostini 		no flags
DetailsFormatted DiffDiff
patch (10.09 KB, patch)
2011-04-13 21:03 PDT, Luiz Agostini 		kling: review-
DetailsFormatted DiffDiff
patch (9.85 KB, patch)
2011-04-15 11:52 PDT, Luiz Agostini 		kling: review+
kling: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Luiz Agostini
Comment 1 2011-03-25 01:44:06 PDT
Created attachment 86910 [details] patch please review
Jocelyn Turcotte
Comment 2 2011-03-28 07:37:43 PDT
I'm no official reviewer but this looks good to me.
Luiz Agostini
Comment 3 2011-04-13 21:03:11 PDT
Created attachment 89525 [details] patch
Andreas Kling
Comment 4 2011-04-14 09:37:28 PDT
Comment on attachment 89525 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=89525&action=review > Source/WebCore/ChangeLog:12 > + - Ignoring status code 404 because application cache depends on it. This should be in a separate patch with a test. :)
Andreas Kling
Comment 5 2011-04-14 09:37:43 PDT
Comment on attachment 89525 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=89525&action=review > Source/WebCore/ChangeLog:12 > + - Ignoring status code 404 because application cache depends on it. This should be in a separate patch with a test. :)
Luiz Agostini
Comment 6 2011-04-15 11:52:53 PDT
Created attachment 89822 [details] patch
Andreas Kling
Comment 7 2011-04-15 12:11:07 PDT
Comment on attachment 89822 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=89822&action=review Another nice cleanup. :) r=me with some minor fixes before landing: > Source/WebCore/platform/network/qt/QNetworkReplyHandler.h:78 > + bool redirected() const { return m_redirectionTargetUrl.isValid(); } wasRedirected() would read nicer IMO. > Source/WebCore/platform/network/qt/QNetworkReplyHandler.h:97 > + int m_statusCode; This is not used anywhere, should be removed.
Luiz Agostini
Comment 8 2011-05-03 11:01:03 PDT
landed. http://trac.webkit.org/changeset/84018
Note You need to log in before you can comment on or make changes to this bug.