| Summary: | [Qt] QNetworkReplyHandler refactoring: some adjustments | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Luiz Agostini <luiz> | ||||||||
| Component: | New Bugs | Assignee: | Luiz Agostini <luiz> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | benjamin, cmarcelo, hausmann, jturcotte, kenneth, kling, menard | ||||||||
| Priority: | P3 | Keywords: | Qt | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Luiz Agostini
2011-03-25 01:39:53 PDT
Created attachment 86910 [details]
patch
please review
I'm no official reviewer but this looks good to me. Created attachment 89525 [details]
patch
Comment on attachment 89525 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=89525&action=review > Source/WebCore/ChangeLog:12 > + - Ignoring status code 404 because application cache depends on it. This should be in a separate patch with a test. :) Comment on attachment 89525 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=89525&action=review > Source/WebCore/ChangeLog:12 > + - Ignoring status code 404 because application cache depends on it. This should be in a separate patch with a test. :) Created attachment 89822 [details]
patch
Comment on attachment 89822 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=89822&action=review Another nice cleanup. :) r=me with some minor fixes before landing: > Source/WebCore/platform/network/qt/QNetworkReplyHandler.h:78 > + bool redirected() const { return m_redirectionTargetUrl.isValid(); } wasRedirected() would read nicer IMO. > Source/WebCore/platform/network/qt/QNetworkReplyHandler.h:97 > + int m_statusCode; This is not used anywhere, should be removed. |