Bug 57091

Summary: <keygen> does not support autofocus
Product: WebKit Reporter: Dominic Cooney <dominicc>
Component: FormsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch none

Description Dominic Cooney 2011-03-25 00:28:02 PDT
The keygen element does not support the autofocus attribute. When a keygen element has the autofocus attribute, it does not automatically get focus.
Comment 1 Dominic Cooney 2011-03-25 00:31:12 PDT
Created attachment 86905 [details]
Patch
Comment 2 Kent Tamura 2011-03-25 00:44:06 PDT
Comment on attachment 86905 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=86905&action=review

> LayoutTests/fast/forms/autofocus-keygen.html:16
> +    shouldBe('focusedElement', 'document.querySelector("keygen")');

I think document.activeElement works instead of focusedElement.

> LayoutTests/fast/forms/autofocus-keygen.html:23
> +successfullyParsed = true;
> +</script>
> +</head>
> +<body onload="onLoad();">

This doesn't follow usual style of our layout tests.

Please do:
 - remove layoutTestController.dumpAsText() in the second <script>
 - add window.jsTestisAsync = true in the second <script>
 - add finishJSTest() at the bottom of onLoad()
 - add <script> for js/resources/js-test-post.js at the bottom of <body>
Comment 3 Dominic Cooney 2011-03-25 00:52:50 PDT
Created attachment 86907 [details]
Patch
Comment 4 Kent Tamura 2011-03-25 00:55:10 PDT
Comment on attachment 86907 [details]
Patch

ok
Comment 5 WebKit Commit Bot 2011-03-25 01:18:50 PDT
Comment on attachment 86907 [details]
Patch

Clearing flags on attachment: 86907

Committed r81947: <http://trac.webkit.org/changeset/81947>
Comment 6 WebKit Commit Bot 2011-03-25 01:18:55 PDT
All reviewed patches have been landed.  Closing bug.