Summary: | [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kristian Amlie <kristian.amlie> | ||||||||||||
Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Minor | CC: | abarth, benjamin, commit-queue, eric, kenneth, kling, ossy, webkit.review.bot | ||||||||||||
Priority: | P3 | Keywords: | EasyFix, Qt, QtTriaged | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | All | ||||||||||||||
OS: | All | ||||||||||||||
Bug Depends on: | 57016 | ||||||||||||||
Bug Blocks: | |||||||||||||||
Attachments: |
|
Description
Kristian Amlie
2011-03-25 00:18:20 PDT
Related to https://bugs.webkit.org/show_bug.cgi?id=57016. Created attachment 86951 [details]
Patch
Created attachment 86952 [details]
Patch
Comment on attachment 86951 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=86951&action=review > Source/WebCore/ChangeLog:8 > + Use explicit convertion for string to avoid depending on the default codec s/convertion/conversion/ Comment on attachment 86952 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=86952&action=review > Source/WebKit2/ChangeLog:8 > + Use explicit convertion for string to avoid depending on the default codec s/convertion/conversion/ Comment on attachment 86951 [details] Patch Landed as r81967. Comment on attachment 86952 [details] Patch Landed: r81968 Created attachment 86957 [details]
Patch
I'll finish the tests later, the diff is already huge and I need to find a way to automate some of the conversions. Comment on attachment 86957 [details]
Patch
Did you performance test this on AIX?
Comment on attachment 86957 [details] Patch Clearing flags on attachment: 86957 Committed r82059: <http://trac.webkit.org/changeset/82059> All reviewed patches have been landed. Closing bug. Reopening, there is still the define to change. Created attachment 87079 [details]
Patch
Created attachment 87082 [details]
Patch
Hopefully it is the last patch. This enable QT_ASCII_CAST_WARNINGS by default and disable it where the warning does not make sense.
Comment on attachment 87082 [details]
Patch
Good luck, monsieur Poulain!
The commit-queue encountered the following flaky tests while processing attachment 87079 [details]: fast/forms/input-appearance-preventDefault.html bug 57194 (author: adele@apple.com) The commit-queue is continuing to process your patch. Comment on attachment 87079 [details] Patch Clearing flags on attachment: 87079 Committed r82082: <http://trac.webkit.org/changeset/82082> Comment on attachment 87082 [details]
Patch
I cq+ this one and I'll check the bots to see if I break any platform.
Comment on attachment 87082 [details] Patch Clearing flags on attachment: 87082 Committed r82125: <http://trac.webkit.org/changeset/82125> All reviewed patches have been landed. Closing bug. Buildfix landed in http://trac.webkit.org/changeset/82134. Unfortunately CQ can't test define changes in project files due to: https://bugs.webkit.org/show_bug.cgi?id=38054 http://trac.webkit.org/changeset/82134 might have broken Leopard Intel Release (Tests) (In reply to comment #18) > (From update of attachment 87079 [details]) > Clearing flags on attachment: 87079 > > Committed r82082: <http://trac.webkit.org/changeset/82082> Typo fix for it landed in http://trac.webkit.org/changeset/82155 |