Bug 57064

Summary: WebFrame forward declares WebURLLoaderOptions as a class when it's a struct.
Product: WebKit Reporter: Bill Budge <bbudge>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dimich, eric, levin, scheib
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed Patch
none
Proposed Patch none

Bill Budge
Reported 2011-03-24 16:39:32 PDT
This causes a build error in Chromium code.
Attachments
Proposed Patch (1.08 KB, text/plain)
2011-03-24 16:41 PDT, Bill Budge 		no flags
Details
Proposed Patch (1.27 KB, patch)
2011-03-24 16:49 PDT, Bill Budge 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Bill Budge
Comment 1 2011-03-24 16:41:30 PDT
Created attachment 86859 [details] Proposed Patch
Bill Budge
Comment 2 2011-03-24 16:44:38 PDT
Comment on attachment 86859 [details] Proposed Patch Gah. I got confused by changes on my checkout. Never mind.
Bill Budge
Comment 3 2011-03-24 16:47:52 PDT
Comment on attachment 86859 [details] Proposed Patch On second thought, this is needed.
Bill Budge
Comment 4 2011-03-24 16:49:32 PDT
Created attachment 86860 [details] Proposed Patch On fourth thought, better make it right.
Eric Seidel (no email)
Comment 5 2011-03-24 17:01:28 PDT
Comment on attachment 86860 [details] Proposed Patch OK.
Eric Seidel (no email)
Comment 6 2011-03-24 17:02:22 PDT
It seems like we should catch this sort of thing with check-webkit-style. Probably by just deprecating "struct" from WebKit code. So rarely does a "struct" really want to be a struct and not just a class Foo { public:
Dmitry Titov
Comment 7 2011-03-24 18:10:46 PDT
Comment on attachment 86860 [details] Proposed Patch Clearing flags on attachment: 86860 Committed r81926: <http://trac.webkit.org/changeset/81926>
Dmitry Titov
Comment 8 2011-03-24 18:10:51 PDT
All reviewed patches have been landed. Closing bug.
Eric Seidel (no email)
Comment 9 2011-04-06 10:38:31 PDT
Comment on attachment 86859 [details] Proposed Patch Cleared review? from obsolete attachment 86859 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).
Note You need to log in before you can comment on or make changes to this bug.