Bug 57062

Summary:

[chromium] Remove deprecated overload of openFileSystem for workers

Product:

WebKit

Reporter:

Adam Klein <adamk>

Component:

WebCore Misc.

Assignee:

Adam Klein <adamk>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, levin

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none

Adam Klein

Reported 2011-03-24 15:52:32 PDT

[chromium] Remove deprecated overload of openFileSystem for workers

Attachments
Patch (1.73 KB, patch) 2011-03-24 15:53 PDT, Adam Klein	no flags	Details Formatted Diff Diff
Patch (1.32 KB, patch) 2011-03-24 16:41 PDT, Adam Klein	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Adam Klein

Comment 1 2011-03-24 15:53:05 PDT

Created attachment 86850 [details] Patch

Adam Klein

Comment 2 2011-03-24 16:41:05 PDT

Created attachment 86858 [details] Patch

Adam Klein

Comment 3 2011-03-24 18:06:12 PDT

+levin, who's reviewed all my recent changes related to workers and filesystems.

David Levin

Comment 4 2011-03-24 18:21:19 PDT

I wonder if we need to roll DEPS for this change to the version of chromium that no longer uses it. WebKit/chromium/DEPS

Adam Klein

Comment 5 2011-03-25 09:28:37 PDT

I'm about to submit the Chromium side of this change (http://codereview.chromium.org/6736012/), but this method is called only on the WebKit side, so the two changes can safely be landed in any order. Landing this one first simply means that the Chromium code will no longer be overriding this method, but providing its own of the same name. This happens to be simpler than usual in this case because the method has a default implementation in WebKit. Otherwise, ordering would be important. I've tested that this works as expected by building with "build-webkit --chromium".

WebKit Commit Bot

Comment 6 2011-03-25 11:26:32 PDT

Comment on attachment 86858 [details] Patch Clearing flags on attachment: 86858 Committed r81972: <http://trac.webkit.org/changeset/81972>

WebKit Commit Bot

Comment 7 2011-03-25 11:26:36 PDT

All reviewed patches have been landed. Closing bug.

WebKit Commit Bot

Comment 8 2011-03-25 12:29:43 PDT

The commit-queue encountered the following flaky tests while processing attachment 86858 [details]: fast/workers/storage/use-same-database-in-page-and-workers.html bug 50995 (author: dumi@chromium.org) The commit-queue is continuing to process your patch.

Note You need to log in before you can comment on or make changes to this bug.