| Summary: | [chromium] Remove deprecated overload of openFileSystem for workers | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Klein <adamk> | ||||||
| Component: | WebCore Misc. | Assignee: | Adam Klein <adamk> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, levin | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
|
Description
Adam Klein
2011-03-24 15:52:32 PDT
Created attachment 86850 [details]
Patch
Created attachment 86858 [details]
Patch
+levin, who's reviewed all my recent changes related to workers and filesystems. I wonder if we need to roll DEPS for this change to the version of chromium that no longer uses it. WebKit/chromium/DEPS I'm about to submit the Chromium side of this change (http://codereview.chromium.org/6736012/), but this method is called only on the WebKit side, so the two changes can safely be landed in any order. Landing this one first simply means that the Chromium code will no longer be overriding this method, but providing its own of the same name. This happens to be simpler than usual in this case because the method has a default implementation in WebKit. Otherwise, ordering would be important. I've tested that this works as expected by building with "build-webkit --chromium". Comment on attachment 86858 [details] Patch Clearing flags on attachment: 86858 Committed r81972: <http://trac.webkit.org/changeset/81972> All reviewed patches have been landed. Closing bug. The commit-queue encountered the following flaky tests while processing attachment 86858 [details]: fast/workers/storage/use-same-database-in-page-and-workers.html bug 50995 (author: dumi@chromium.org) The commit-queue is continuing to process your patch. |