Bug 57041

Summary: [fileapi] Make FileError and FileException accessible from WorkerContext
Product: WebKit Reporter: Adam Klein <adamk>
Component: New BugsAssignee: Adam Klein <adamk>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, ericu, eric, kinuko, levin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Indentation fixed none

Adam Klein
Reported 2011-03-24 12:17:25 PDT
[fileapi] Make FileError and FileException accessible from WorkerContext
Attachments
Patch (4.21 KB, patch)
2011-03-24 12:18 PDT, Adam Klein 		no flags
DetailsFormatted DiffDiff
Indentation fixed (3.96 KB, patch)
2011-03-24 13:19 PDT, Adam Klein 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Klein
Comment 1 2011-03-24 12:18:31 PDT
Created attachment 86808 [details] Patch
David Levin
Comment 2 2011-03-24 13:10:19 PDT
Comment on attachment 86808 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=86808&action=review r+ but cq- due to indenting issue. > Source/WebCore/workers/WorkerContext.idl:116 > + attribute [EnabledAtRuntime=FileSystem] FlagsConstructor Flags; The indentation is on purpose and follows the format done typically in spec iirc. Hint look at where attribute would be if readonly preceded it. > Source/WebCore/workers/WorkerContext.idl:117 > + attribute [EnabledAtRuntime=FileSystem] FileErrorConstructor FileError; Ok, FileError.idl has NoStaticTables attribute. > Source/WebCore/workers/WorkerContext.idl:118 > + attribute [EnabledAtRuntime=FileSystem] FileExceptionConstructor FileException; Ok, FileException.idl has NoStaticTables attribute.
Adam Klein
Comment 3 2011-03-24 13:19:10 PDT
Created attachment 86820 [details] Indentation fixed
WebKit Commit Bot
Comment 4 2011-03-24 15:13:29 PDT
Comment on attachment 86820 [details] Indentation fixed Clearing flags on attachment: 86820 Committed r81906: <http://trac.webkit.org/changeset/81906>
WebKit Commit Bot
Comment 5 2011-03-24 15:13:34 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 6 2011-03-24 16:16:26 PDT
http://trac.webkit.org/changeset/81906 might have broken Leopard Intel Debug (Tests)
Note You need to log in before you can comment on or make changes to this bug.