Bug 57025

Summary: [GTK] [PATCH] Avoid critical warning when free-ing list of plugins
Product: WebKit Reporter: Priit Laes (IRC: plaes) <plaes>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mrobinson, webkit.review.bot
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
plugins-critical-warning-fix.patch
none
plugins-critical-warning-fix.patch none

Priit Laes (IRC: plaes)
Reported 2011-03-24 09:28:05 PDT
Critical error is printed to console when there are no plugins present. This is because plugin list is stored inside GSList that is NULL by default (ie if no elements are present). But the function that free's the plugin list has g_return_if_fail(list) that emits the ciritical error when list is NULL.
Attachments
plugins-critical-warning-fix.patch (1.91 KB, patch)
2011-03-24 09:33 PDT, Priit Laes (IRC: plaes) 		no flags
DetailsFormatted DiffDiff
plugins-critical-warning-fix.patch (1.93 KB, patch)
2011-03-24 09:37 PDT, Priit Laes (IRC: plaes) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Priit Laes (IRC: plaes)
Comment 1 2011-03-24 09:33:07 PDT
Created attachment 86782 [details] plugins-critical-warning-fix.patch
WebKit Review Bot
Comment 2 2011-03-24 09:34:52 PDT
Attachment 86782 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/gtk/ChangeLog', u'Source/Web..." exit_code: 1 Source/WebKit/gtk/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] Source/WebKit/gtk/ChangeLog:10: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Priit Laes (IRC: plaes)
Comment 3 2011-03-24 09:37:01 PDT
Created attachment 86783 [details] plugins-critical-warning-fix.patch
WebKit Commit Bot
Comment 4 2011-03-25 03:33:37 PDT
Comment on attachment 86783 [details] plugins-critical-warning-fix.patch Clearing flags on attachment: 86783 Committed r81952: <http://trac.webkit.org/changeset/81952>
WebKit Commit Bot
Comment 5 2011-03-25 03:33:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.