Bug 57016

Summary: [Qt] Avoid ASCII-cast warnings for WebKit.
Product: WebKit Reporter: Kristian Amlie <kristian.amlie>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Critical CC: abarth, benjamin, commit-queue, eric, webkit.review.bot
Priority: P1 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 57087    
Attachments:
Description Flags
Avoided-ASCII-cast-warnings-for-WebKit none

Kristian Amlie
Reported 2011-03-24 08:14:26 PDT
Normally they won't be enabled anyway, but if you build webkit from within the Qt mother repository it will pick up Qt's default build settings, which do enable it. We need to disable them because warnings are treated as errors and there are way too many of them in the WebKit code.
Attachments
Avoided-ASCII-cast-warnings-for-WebKit (2.03 KB, patch)
2011-03-24 08:16 PDT, Kristian Amlie 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kristian Amlie
Comment 1 2011-03-24 08:16:45 PDT
Created attachment 86774 [details] Avoided-ASCII-cast-warnings-for-WebKit
Benjamin Poulain
Comment 2 2011-03-24 10:23:19 PDT
Comment on attachment 86774 [details] Avoided-ASCII-cast-warnings-for-WebKit How many error do you get? Could you create a task about removing that line?
WebKit Commit Bot
Comment 3 2011-03-24 10:48:02 PDT
Comment on attachment 86774 [details] Avoided-ASCII-cast-warnings-for-WebKit Clearing flags on attachment: 86774 Committed r81876: <http://trac.webkit.org/changeset/81876>
WebKit Commit Bot
Comment 4 2011-03-24 10:48:07 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 5 2011-03-24 13:06:58 PDT
http://trac.webkit.org/changeset/81876 might have broken GTK Linux 32-bit Debug The following tests are not passing: svg/W3C-SVG-1.1/animate-elem-46-t.svg svg/W3C-SVG-1.1/animate-elem-82-t.svg
Kristian Amlie
Comment 6 2011-03-25 00:21:04 PDT
(In reply to comment #2) > (From update of attachment 86774 [details]) > How many error do you get? I didn't count exactly, since it causes the build to fail. But in a parallel build, it stacked up quite a few. > Could you create a task about removing that line? https://bugs.webkit.org/show_bug.cgi?id=57087 (In reply to comment #5) > http://trac.webkit.org/changeset/81876 might have broken GTK Linux 32-bit Debug > The following tests are not passing: > svg/W3C-SVG-1.1/animate-elem-46-t.svg > svg/W3C-SVG-1.1/animate-elem-82-t.svg I don't see how the submitted patch can have any effect on GTK. It doesn't even use qmake to build, does it?
Benjamin Poulain
Comment 7 2011-03-25 02:37:55 PDT
(In reply to comment #6) > > Could you create a task about removing that line? > > https://bugs.webkit.org/show_bug.cgi?id=57087 Thanks. > (In reply to comment #5) > > http://trac.webkit.org/changeset/81876 might have broken GTK Linux 32-bit Debug > > The following tests are not passing: > > svg/W3C-SVG-1.1/animate-elem-46-t.svg > > svg/W3C-SVG-1.1/animate-elem-82-t.svg > > I don't see how the submitted patch can have any effect on GTK. It doesn't even use qmake to build, does it? Don't worry about that. The bot just send the alert for all the changes since the last successful testing.
Note You need to log in before you can comment on or make changes to this bug.