Bug 56990

Summary:

rename -webkit-any to -webkit-matches

Product:

WebKit

Reporter:

Ojan Vafai <ojan>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

NEW

Severity:

Normal

CC:

dbaron, eric, hyatt, jschoi, koivisto, m.goleb+bugzilla, noel.gordon, phiw2

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	ojan: review-

Ojan Vafai

Reported 2011-03-23 20:39:36 PDT

Not sure if we should do this quite yet, but selectors 4 added :matches instead of :any. I'm interested to see what Mozilla folk think. I don't care either way. Both names seem fine. http://dev.w3.org/csswg/selectors4/#matches

Attachments
Patch (34.78 KB, patch) 2011-06-16 00:39 PDT, Kentaro Hara	no flags	Details Formatted Diff Diff
Patch (32.01 KB, patch) 2011-06-16 02:50 PDT, Kentaro Hara	ojan: review-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Kentaro Hara

Comment 1 2011-06-16 00:39:26 PDT

Created attachment 97414 [details] Patch

Kent Tamura

Comment 2 2011-06-16 02:09:47 PDT

Comment on attachment 97414 [details] Patch Why do you replace -webkit-any-link with -webkit-matches-link?

Hajime Morrita

Comment 3 2011-06-16 02:11:53 PDT

Comment on attachment 97414 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97414&action=review This review is just for nit-picking. I have no idea if this change is desirable so I'd like hear from expert folks... > LayoutTests/ChangeLog:4 > + Could you explain your change briefly? > LayoutTests/ChangeLog:8 > + Need a short description and bug URL (OOPS!) We don't need this line. > Source/WebCore/ChangeLog:7 > + You should mention about tests, even if you do't add any new test.

Kentaro Hara

Comment 4 2011-06-16 02:50:36 PDT

Created attachment 97428 [details] Patch

Kentaro Hara

Comment 5 2011-06-16 02:54:12 PDT

Comment on attachment 97414 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97414&action=review >> LayoutTests/ChangeLog:4 >> + > > Could you explain your change briefly? Done. >> LayoutTests/ChangeLog:8 >> + Need a short description and bug URL (OOPS!) > > We don't need this line. Removed it. >> Source/WebCore/ChangeLog:7 >> + > > You should mention about tests, even if you do't add any new test. Done.

Ojan Vafai

Comment 6 2011-06-16 10:03:49 PDT

I'm still not convinced we want to do this. By using :any we match Mozilla. Also, I'm increasingly of the opinion that :matches is a worse name. It's longer and less clear that it's an "or" relation versus an "and" relation. I suppose I should bring this up on the www-style mailing list and just get it resolved there.

Eric Seidel (no email)

Comment 7 2011-06-16 10:35:18 PDT

Ojan, please write to www-style and r- this patch when you do.

Ojan Vafai

Comment 8 2011-06-16 18:55:20 PDT

Comment on attachment 97428 [details] Patch R- until this discussion is resolved. http://lists.w3.org/Archives/Public/www-style/2011Jun/0442.html

J. S. Choi

Comment 9 2018-02-04 07:16:06 PST

There has been recent activity in the CSSWG around :matches() and whether to rename it to better reflect its relationship with :not(). See these GitHub issue threads: https://github.com/w3c/csswg-drafts/issues/2143 https://github.com/w3c/csswg-drafts/issues/1027

Note You need to log in before you can comment on or make changes to this bug.