Bug 56947

Summary: [chromium] WebGLRenderingContext and other DOMWindow properties should remain if WebGL is disabled
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cmarrin, eric, jamesr, scheib, vangelis, webkit.review.bot, zmo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch jamesr: review+, kbr: commit-queue-

Description Kenneth Russell 2011-03-23 12:12:48 PDT 
Currently in the Chromium port, if WebGL is disabled via the command line argument --disable-webgl or because of a blacklist entry, the WebGLRenderingContext and other DOMWindow properties are removed via the RuntimeEnabledFeatures mechanism. This is not the desired behavior; it makes it appear that the browser is not capable of running WebGL, when in fact the graphics card is the problem.

The associated Chromium bug is http://crbug.com/77110 .
Comment 1 Kenneth Russell 2011-03-23 14:53:50 PDT 
Created attachment 86693 [details]
Patch
Comment 2 James Robinson 2011-03-23 16:21:46 PDT 
Comment on attachment 86693 [details]
Patch

OK
Comment 3 Kenneth Russell 2011-03-23 16:25:09 PDT 
Committed r81821: <http://trac.webkit.org/changeset/81821>
Comment 4 WebKit Review Bot 2011-03-23 16:53:10 PDT 
http://trac.webkit.org/changeset/81821 might have broken Chromium Linux Release
Comment 5 Vincent Scheib 2011-03-23 22:05:49 PDT 
This has broken compilation of (In reply to comment #4)
> http://trac.webkit.org/changeset/81821 might have broken Chromium Linux Release

Fixed with http://codereview.chromium.org/6732015