Bug 56947 - [chromium] WebGLRenderingContext and other DOMWindow properties should remain if WebGL is disabled
Summary: [chromium] WebGLRenderingContext and other DOMWindow properties should remain...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kenneth Russell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-23 12:12 PDT by Kenneth Russell
Modified: 2011-03-23 22:05 PDT (History)
8 users (show)

See Also:

Attachments
Patch (8.21 KB, patch)
2011-03-23 14:53 PDT, Kenneth Russell 		jamesr: review+
kbr: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2011-03-23 12:12:48 PDT 
Currently in the Chromium port, if WebGL is disabled via the command line argument --disable-webgl or because of a blacklist entry, the WebGLRenderingContext and other DOMWindow properties are removed via the RuntimeEnabledFeatures mechanism. This is not the desired behavior; it makes it appear that the browser is not capable of running WebGL, when in fact the graphics card is the problem.

The associated Chromium bug is http://crbug.com/77110 .
Comment 1 Kenneth Russell 2011-03-23 14:53:50 PDT 
Created attachment 86693 [details]
Patch
Comment 2 James Robinson 2011-03-23 16:21:46 PDT 
Comment on attachment 86693 [details]
Patch

OK
Comment 3 Kenneth Russell 2011-03-23 16:25:09 PDT 
Committed r81821: <http://trac.webkit.org/changeset/81821>
Comment 4 WebKit Review Bot 2011-03-23 16:53:10 PDT 
http://trac.webkit.org/changeset/81821 might have broken Chromium Linux Release
Comment 5 Vincent Scheib 2011-03-23 22:05:49 PDT 
This has broken compilation of (In reply to comment #4)
> http://trac.webkit.org/changeset/81821 might have broken Chromium Linux Release

Fixed with http://codereview.chromium.org/6732015